Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests to the latest version #560

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

chigby
Copy link
Contributor

@chigby chigby commented Nov 6, 2018

This pull request bumps requests to the latest version, which addresses CVE-2018-18074 (a minor issue, but one we'd like to avoid nonetheless). Also updates molecule to the latest version to get around a dependency of that library which was also triggering a safety error.

Refs freedomofpress/fpf-www-projects#28

The latest version addresses CVE-2018-18074 (a minor issue, but one
we'd like to avoid nonetheless).
This required altering an environment variable name to be all caps,
since that's apparently what the new version of molecule now checks
for.
@msheiny
Copy link
Contributor

msheiny commented Nov 6, 2018

Jesus -- i dont know why this was so hard to pull out pytest-dev/pytest#4304

At some-point a third-party plugin called stepwise was merged into
pytest. This causes a big ol' issue with the latest pytest release.

See this bug report (where i got the work-around from):
pytest-dev/pytest#4304
This wasnt really running at all times and more importantly wasnt
running before django processed started. Fixxxxxxed
@harrislapiroff harrislapiroff merged commit 9dd771f into master Nov 6, 2018
@harrislapiroff harrislapiroff deleted the update-requests-version branch November 6, 2018 21:47
@conorsch
Copy link
Contributor

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants